Skip to content

http: create an option for setting a maximum size for uri parsing #26553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caiolrm wants to merge 8 commits into from
Closed

http: create an option for setting a maximum size for uri parsing #26553

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45fa652
http: create an option for setting a maximum size for uri parsing
caiolrm Mar 9, 2019
3218828
http: fix style and naming
caiolrm Mar 10, 2019
197d264
http: fix doc added version to replaceme
caiolrm Mar 10, 2019
e7ade8b
http: fixing comment because lint
caiolrm Mar 10, 2019
78dfcf7
http: requiring common first
caiolrm Mar 10, 2019
710e830
http: splitting the limit check of header and uri
caiolrm Mar 10, 2019
38307dc
http: fixing tests
caiolrm Mar 10, 2019
93e384a
http: fix the comment to reflect the actual currentSize composition
caiolrm Mar 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
http: fix the comment to reflect the actual currentSize composition
  • Loading branch information
@caiolrm
caiolrm committed Mar 10, 2019
commit 93e384a75bd5ff8b528437e9c8a937575d27bb59
2 changes: 1 addition & 1 deletion test/sequential/test-http-max-http-headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ const test2 = common.mustCall(() => {
'Agent: nod2\r\n' +
'X-CRASH: ';

// /, Host, localhost, Agent, node, X-CRASH, a...
// Host, localhost, Agent, node, X-CRASH, a...
const currentSize = 4 + 9 + 5 + 4 + 7;
Copy link
Copy Markdown
Member

@mcollina mcollina Mar 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain this change?

Copy link
Copy Markdown
Author

@caiolrm caiolrm Mar 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currentSize is being used by fillHeaders to subtract from the max header size and generate a header value with a length that makes the total header size hit the limit. Since the implementation at node_http_parser_impl.h when using llhttp doesn't count the url size towards the header size after the changes, there's no point considering the "/" size when using fillHeaders anymore.

headers = fillHeaders(headers, currentSize);

Expand Down