Skip to content

src: use CHECK(false) in switch default case #26502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nitsakh wants to merge 6 commits into from
Closed

src: use CHECK(false) in switch default case #26502

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a828ea3
src: update UNREACHABLE macro to take a string
nitsakh Mar 8, 2019
7ed7094
Address review comment
nitsakh Mar 12, 2019
023e720
Rename macro used
nitsakh Mar 13, 2019
f92f828
Update args
nitsakh Mar 14, 2019
a59024b
Update based on comments
nitsakh Mar 18, 2019
6d4b624
Added space after colon in UNREACHABLE macro definition
nitsakh Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update args
  • Loading branch information
@nitsakh
nitsakh committed May 15, 2019
commit f92f8280396dfadfaf58130a508ba1132841bea1
2 changes: 1 addition & 1 deletion src/util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ void DumpBacktrace(FILE* fp);
do { \
/* Make sure that this struct does not end up in inline code, but */ \
/* rather in a read-only data section when modifying this code. */ \
constexpr node::AssertionInfo args = { \
const node::AssertionInfo args = { \
__FILE__ ":" STRINGIFY(__LINE__), #expr, PRETTY_FUNCTION_NAME \
}; \
Comment thread
BridgeAR marked this conversation as resolved.
Outdated
node::Assert(args); \
Expand Down