Skip to content

process: move more dependency of environment variables to pre-execution #26466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

process: move more dependency of environment variables to pre-execution #26466

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdbcd0f
process: call `prepareMainThreadExecution` in `node inspect`
joyeecheung Mar 6, 2019
0e97fa3
process: set up process warning handler in pre-execution
joyeecheung Mar 6, 2019
410c588
process: handle process.env.NODE_V8_COVERAGE in pre-execution
joyeecheung Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
process: call prepareMainThreadExecution in node inspect 
Since we should treat the node-inspect as third-party
user code.
  • Loading branch information
@joyeecheung
joyeecheung committed Mar 6, 2019
commit bdbcd0f6143fd8d208debcad7fc5474186c8cbb2
6 changes: 6 additions & 0 deletions lib/internal/main/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

// `node inspect ...` or `node debug ...`

const {
prepareMainThreadExecution
} = require('internal/bootstrap/pre_execution');

prepareMainThreadExecution();

if (process.argv[1] === 'debug') {
process.emitWarning(
'`node debug` is deprecated. Please use `node inspect` instead.',
Expand Down