Skip to content

build,deps: less warnings from V8 #26405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refack merged 1 commit into from
Mar 6, 2019
+1 −0
Merged

build,deps: less warnings from V8 #26405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build,deps: less warnings from V8 
PR-URL: #26405
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
@refack
refack committed Mar 6, 2019
commit d38cd82513584c9d7c463aa809e5ee483a66eae3
1 change: 1 addition & 0 deletions deps/v8/gypfiles/toolchain.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,6 +1393,7 @@
], # conditions
}, # Release
}, # configurations
'cflags': [ '-Wno-type-limits', ],
'msvs_disabled_warnings': [
4245, # Conversion with signed/unsigned mismatch.
4267, # Conversion with possible loss of data.
Expand Down