Skip to content

src: refactor Environment::GetCurrent(isolate) usage #26376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 5 commits into from
Closed

src: refactor Environment::GetCurrent(isolate) usage #26376

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3509d74
src: refactor `Environment::GetCurrent(isolate)` usage
addaleax Feb 24, 2019
d85419d
src: prefer to get `Environment` from `Context`
addaleax Feb 24, 2019
322041b
src: allow running tasks without `Environment`
addaleax Feb 24, 2019
6b766af
src: forbid handle allocations from Platform tasks
addaleax Feb 24, 2019
7f99bbb
fixup! src: prefer to get `Environment` from `Context`
addaleax Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: prefer to get Environment from Context
  • Loading branch information
@addaleax
addaleax authored Mar 1, 2019
commit 7f99bbb99e5ef7b4a8909f22a710457486d03580
1 change: 0 additions & 1 deletion src/node_perf.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,6 @@ inline Local<Value> GetName(Local<Function> fn) {
// execution.
void TimerFunctionCall(const FunctionCallbackInfo<Value>& args) {
Isolate* isolate = args.GetIsolate();
HandleScope scope(isolate);
Local<Context> context = isolate->GetCurrentContext();
Environment* env = Environment::GetCurrent(context);
CHECK_NOT_NULL(env);
Expand Down