Skip to content

test: eliminate port collision in test-cluster-net-listen-ipv6only-rr #26298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gireeshpunathil merged 1 commit into from
Feb 28, 2019
Merged

test: eliminate port collision in test-cluster-net-listen-ipv6only-rr #26298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: eliminate port collision 
In test test-cluster-net-listen-ipv6only-rr, the cluster member that
listens to `any` port actually has the potential to `grab` any port
from the environment which when passed onto the master causes
collision when it tries to listen on.

Moving the test to sequential alone is not sufficient as the cluster
member can in theory catch on to the admin ports on the host.

Assigning static port alone is also not sufficient, as it can interfere
with other running tests in the parallel category which would be mostly
running with `port: any` fashion.

So move to sequential, and use a static port.

Fixes: #25813
PR-URL: #26298
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
  • Loading branch information
@gireeshpunathil
gireeshpunathil committed Feb 28, 2019
commit 4a3928e125bb1ab7242e8134f911b6c71551bd75
9 changes: 7 additions & 2 deletions ...el/test-cluster-net-listen-ipv6only-rr.js → ...al/test-cluster-net-listen-ipv6only-rr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,14 @@ if (cluster.isMaster) {
workers.set(i, worker);
}
} else {
// As the cluster member has the potential to grab any port
// from the environment, this can cause collision when master
// obtains the port from cluster member and tries to listen on.
// So move this to sequential, and provide a static port.
// Refs: https://github.com/nodejs/node/issues/25813
net.createServer().listen({
host,
port: 0,
host: host,
port: common.PORT,
ipv6Only: true,
}, common.mustCall());
}