Skip to content

[v10.x backport] Update openssl1.1.1a #26270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-github wants to merge 12 commits into from
Closed

[v10.x backport] Update openssl1.1.1a #26270

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
be6a3a1
tls: add min/max protocol version options
sam-github May 6, 2018
8e4a622
doc: fix REPLACEME for tls min/max protocol option
sam-github Nov 30, 2018
39d09ce
deps: upgrade openssl sources to 1.1.1a
sam-github Dec 11, 2018
e8b39cf
deps: fix gyp/gypi for openssl-1.1.1
shigeki May 5, 2018
af05709
deps: fix MacOS and Win build for OpenSSL-1.1.1
shigeki Nov 1, 2018
08cf226
deps: add s390 asm rules for OpenSSL-1.1.1
shigeki Mar 7, 2018
0cf96fb
deps: add only avx2 configs for OpenSSL-1.1.1
shigeki Nov 8, 2018
87ff9f7
deps: fix for non GNU assembler in AIX
shigeki Nov 15, 2018
eb3470a
doc: fix assembler requirement for OpenSSL-1.1.1
shigeki Nov 10, 2018
312dcc3
deps: update archs files for OpenSSL-1.1.1a
sam-github Feb 23, 2019
6be596d
tls: workaround handshakedone in renegotiation
shigeki Sep 12, 2018
d502073
test: assert on client and server side seperately
sam-github Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tls: workaround handshakedone in renegotiation 
`SSL_CB_HANDSHAKE_START` and `SSL_CB_HANDSHAKE_DONE` are called
sending HelloRequest in OpenSSL-1.1.1.
We need to check whether this is in a renegotiation state or not.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
  • Loading branch information
@shigeki @sam-github
shigeki authored and sam-github committed Feb 28, 2019
commit 6be596d09fd746fb8036b07a62d1ea49c2354bc2
5 changes: 4 additions & 1 deletion src/tls_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,10 @@ void TLSWrap::SSLInfoCallback(const SSL* ssl_, int where, int ret) {
}
}

if (where & SSL_CB_HANDSHAKE_DONE) {
// SSL_CB_HANDSHAKE_START and SSL_CB_HANDSHAKE_DONE are called
// sending HelloRequest in OpenSSL-1.1.1.
// We need to check whether this is in a renegotiation state or not.
if (where & SSL_CB_HANDSHAKE_DONE && !SSL_renegotiate_pending(ssl)) {
c->established_ = true;
Local<Value> callback = object->Get(env->onhandshakedone_string());
if (callback->IsFunction()) {
Expand Down