Skip to content

util: improve inspect compact #26269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 3 commits into from
Closed

util: improve inspect compact #26269

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd1ac3d
util: add compact depth mode
BridgeAR Feb 22, 2019
2163a25
util: group array elements together
BridgeAR Feb 22, 2019
67f5fb3
fixup: fix typo
BridgeAR Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: fix typo
  • Loading branch information
@BridgeAR
BridgeAR committed Feb 28, 2019
commit 67f5fb3d30b40e22a077dfe878b8d4b04bd64c5f
6 changes: 3 additions & 3 deletions lib/internal/util/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,7 +1309,7 @@ function formatProperty(ctx, value, recurseTimes, key, type) {
return `${name}:${extra}${str}`;
}

function isBellowBreakLength(ctx, output, start) {
function isBelowBreakLength(ctx, output, start) {
// Each entry is separated by at least a comma. Thus, we start with a total
// length of at least `output.length`. In addition, some cases have a
// whitespace in-between each other that is added to the total as well.
Expand Down Expand Up @@ -1337,7 +1337,7 @@ function reduceToSingleString(ctx, output, base, braces, combine = false) {
// that may reduce `breakLength`.
const start = output.length + ctx.indentationLvl +
braces[0].length + base.length + 10;
if (isBellowBreakLength(ctx, output, start)) {
if (isBelowBreakLength(ctx, output, start)) {
return `${base ? `${base} ` : ''}${braces[0]} ${join(output, ', ')} ` +
braces[1];
}
Expand All @@ -1349,7 +1349,7 @@ function reduceToSingleString(ctx, output, base, braces, combine = false) {
}
// Line up all entries on a single line in case the entries do not exceed
// `breakLength`.
if (isBellowBreakLength(ctx, output, 0)) {
if (isBelowBreakLength(ctx, output, 0)) {
return `${braces[0]}${base ? ` ${base}` : ''} ${join(output, ', ')} ` +
braces[1];
}
Expand Down