Skip to content

tty: improve color detection #26264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

tty: improve color detection #26264

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a387e92
test: always activate colors if necessary
BridgeAR Feb 28, 2019
0f37b28
tty: improve color detection
BridgeAR Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: always activate colors if necessary
  • Loading branch information
@BridgeAR
BridgeAR committed Feb 28, 2019
commit a387e9274b6dfebd3309c108d6ce44f59612084f
4 changes: 4 additions & 0 deletions test/pseudo-tty/test-assert-colors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ const assert = require('assert').strict;
try {
// Activate colors even if the tty does not support colors.
process.env.COLORTERM = '1';
// Make sure TERM is not set to e.g., 'dumb' and NODE_DISABLE_COLORS is not
// active.
process.env.TERM = 'FOOBAR';
delete process.env.NODE_DISABLE_COLORS;
assert.deepStrictEqual([1, 2, 2, 2], [2, 2, 2, 2]);
} catch (err) {
const expected = 'Expected values to be strictly deep-equal:\n' +
Expand Down