Skip to content

process: fix calculation in process.uptime() #26206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

process: fix calculation in process.uptime() #26206

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd09f7f
process: fix calculation in process.uptime()
joyeecheung Feb 19, 2019
a6ea194
process: move test-process-uptime to parallel
joyeecheung Feb 19, 2019
fd7520e
fixup! process: move test-process-uptime to parallel
Trott Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
process: move test-process-uptime to parallel 
In addition, do not make too many assumptions about the startup
time and timer latency in test-process-uptime. Instead only test
that the value is likely in the correct unit (seconds) and it should
be increasing in subsequent calls.
  • Loading branch information
@joyeecheung @Trott
joyeecheung authored and Trott committed Feb 19, 2019
commit a6ea194f008451603628801d76d0d82cf95226cd
14 changes: 7 additions & 7 deletions test/pummel/test-process-uptime.js → test/parallel/test-process-uptime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,18 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
require('../common');
const common = require('../common');
Copy link
Copy Markdown
Member

@Trott Trott Feb 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const common = require('../common');
require('../common');

const assert = require('assert');

console.error(process.uptime());
assert.ok(process.uptime() <= 2);
// Add some wiggle room for different platforms.
// Verify that the returned value is in seconds -
// 15 seconds should be a good estimate.
assert.ok(process.uptime() <= 15);

const original = process.uptime();

setTimeout(function() {
const uptime = process.uptime();
// some wiggle room to account for timer
// granularity, processor speed, and scheduling
assert.ok(uptime >= original + 2);
assert.ok(uptime <= original + 3);
}, 2000);
assert.ok(original < uptime);
}, 10);