Skip to content

test: increase run time in test-worker-prof #26172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

test: increase run time in test-worker-prof #26172

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
302a269
test: increase run time in test-worker-prof
addaleax Feb 17, 2019
a56d876
fixup! test: increase run time in test-worker-prof
addaleax Feb 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: increase run time in test-worker-prof 
This test has occasionally been failing on Windows since it
was added, with 6 instead of 15 ticks being seen.

Increasing the duration of the test should make it more reliable.
  • Loading branch information
@addaleax
addaleax committed Feb 17, 2019
commit 302a26924be04a6d73b6d75e9170c888871efb1b
7 changes: 4 additions & 3 deletions test/parallel/test-worker-prof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ if (!common.isMainThread)
if (process.argv[2] === 'child') {
const spin = `
const start = Date.now();
while (Date.now() - start < 200);
while (Date.now() - start < 1000);
`;
new Worker(spin, { eval: true });
eval(spin);
Expand All @@ -32,10 +32,11 @@ for (const logfile of logfiles) {
const lines = fs.readFileSync(logfile, 'utf8').split('\n');
const ticks = lines.filter((line) => /^tick,/.test(line)).length;

// Test that at least 20 ticks have been recorded for both parent and child
// Test that at least 15 ticks have been recorded for both parent and child
// threads. When not tracking Worker threads, only 1 or 2 ticks would
// have been recorded.
// When running locally on x64 Linux, this number is usually at least 150
// When running locally on x64 Linux, this number is usually at least 700
// for both threads, so 15 seems like a very safe threshold.
console.log(ticks)
Comment thread
addaleax marked this conversation as resolved.
Outdated
assert(ticks >= 15, `${ticks} >= 15`);
}