Skip to content

test: remove duplicated buffer negative allocation test #26160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZYSzys wants to merge 1 commit into from
Closed

test: remove duplicated buffer negative allocation test #26160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove duplicated buffer negative allocation test
  • Loading branch information
@ZYSzys
ZYSzys committed Feb 22, 2019
commit 283bb601f417c8aa8532d643c9fc0a03ac95131a
17 changes: 0 additions & 17 deletions test/parallel/test-buffer-negative-length.js
View file
Open in desktop

This file was deleted.

8 changes: 7 additions & 1 deletion test/parallel/test-buffer-no-negative-allocation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@

const common = require('../common');
const assert = require('assert');
const { SlowBuffer } = require('buffer');

const msg = common.expectsError({
code: 'ERR_INVALID_OPT_VALUE',
type: RangeError,
message: /^The value "[^"]*" is invalid for option "size"$/
}, 16);
}, 20);

// Test that negative Buffer length inputs throw errors.

Expand All @@ -30,3 +31,8 @@ assert.throws(() => Buffer.allocUnsafeSlow(-Buffer.poolSize), msg);
assert.throws(() => Buffer.allocUnsafeSlow(-100), msg);
assert.throws(() => Buffer.allocUnsafeSlow(-1), msg);
assert.throws(() => Buffer.allocUnsafeSlow(NaN), msg);

assert.throws(() => SlowBuffer(-Buffer.poolSize), msg);
assert.throws(() => SlowBuffer(-100), msg);
assert.throws(() => SlowBuffer(-1), msg);
assert.throws(() => SlowBuffer(NaN), msg);