Skip to content

src: check HasCaught() in JSStream calls #26124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

src: check HasCaught() in JSStream calls #26124

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0822101
src: check HasCaught() in JSStream calls
addaleax Feb 15, 2019
f82df5a
fixup! src: check HasCaught() in JSStream calls
addaleax Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: check HasCaught() in JSStream calls
  • Loading branch information
@addaleax
addaleax committed Feb 15, 2019
commit f82df5a3fd8c210fd2e921abfc340e9393946e47
4 changes: 2 additions & 2 deletions test/parallel/test-worker-http2-generic-streams-terminate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ if (!common.hasCrypto)
const assert = require('assert');
const http2 = require('http2');
const { Duplex } = require('stream');
const { Worker, isMainThread, workerData } = require('worker_threads');
const { Worker, workerData } = require('worker_threads');

// Tests the interaction between terminating a Worker thread and running
// the native SetImmediate queue, which may attempt to perform multiple
// calls into JS even though one already terminates the Worker.

if (isMainThread) {
if (!workerData) {
const counter = new Int32Array(new SharedArrayBuffer(4));
const worker = new Worker(__filename, { workerData: { counter } });
worker.on('exit', common.mustCall(() => {
Expand Down