Skip to content

worker: refactor thread life cycle management #26099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gireeshpunathil wants to merge 4 commits into from
Closed

worker: refactor thread life cycle management #26099

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbf740e
worker: refactor thread life cycle management
gireeshpunathil Feb 17, 2019
8c48265
fixup: address review comments
gireeshpunathil Feb 17, 2019
df06cc4
fixup: don't track irrelevant fields
gireeshpunathil Feb 17, 2019
db9edc1
fixup: leverage TrackInlineField
gireeshpunathil Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: don't track irrelevant fields
  • Loading branch information
@gireeshpunathil
gireeshpunathil committed Mar 1, 2019
commit df06cc43b5f078aa41f7f01b70a994f5f0a749dc
3 changes: 0 additions & 3 deletions src/node_worker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ class Worker : public AsyncWrap {
void JoinThread();

void MemoryInfo(MemoryTracker* tracker) const override {
tracker->TrackFieldWithSize(
"isolate_data", sizeof(IsolateData), "IsolateData");
tracker->TrackFieldWithSize("env", sizeof(Environment), "Environment");
tracker->TrackField("parent_port", parent_port_);
}

Expand Down