Skip to content

process: cleanup and document the bootstrap process in bootstrap/node.js #26033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 5 commits into from
Closed

process: cleanup and document the bootstrap process in bootstrap/node.js #26033

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7950a9
lib: move per_context.js under lib/internal/bootstrap
joyeecheung Feb 10, 2019
9b56d96
process: document the bootstrap process in node.js
joyeecheung Feb 10, 2019
2b70a03
lib: save a copy of Symbol in primordials
joyeecheung Feb 10, 2019
043b540
process: use primordials in bootstrap/node.js
joyeecheung Feb 10, 2019
1672e3b
process: refactor lib/internal/bootstrap/node.js
joyeecheung Feb 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lib: save a copy of Symbol in primordials
  • Loading branch information
@joyeecheung
joyeecheung committed Feb 10, 2019
commit 2b70a034c69cbb617ed7b481fd6863788c08e788
3 changes: 2 additions & 1 deletion lib/internal/bootstrap/primordials.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ primordials.SafePromise = makeSafe(
'Function',
'Object',
'RegExp',
'String'
'String',
'Symbol',
].forEach((name) => {
const target = primordials[name] = Object.create(null);
copyProps(global[name], target);
Expand Down