Skip to content

worker: set up child Isolate inside Worker thread #26011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 7 commits into from
Closed

worker: set up child Isolate inside Worker thread #26011

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f2eecf4
worker: pre-allocate thread id
addaleax Feb 8, 2019
406c805
worker: set up child Isolate inside Worker thread
addaleax Feb 8, 2019
2265a47
test: add `Worker` + `--prof` regression test
addaleax Feb 8, 2019
482715b
fixup! worker: pre-allocate thread id
addaleax Feb 9, 2019
542d3bb
fixup! worker: set up child Isolate inside Worker thread
addaleax Feb 9, 2019
124ce9b
fixup! fixup! worker: set up child Isolate inside Worker thread
addaleax Feb 9, 2019
557e241
fixup! worker: set up child Isolate inside Worker thread
addaleax Feb 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add Worker + --prof regression test 
Fixes: #24016
  • Loading branch information
@addaleax
addaleax committed Feb 8, 2019
commit 2265a476cd1a1a3a22f821d2715b35e857a7e17c
41 changes: 41 additions & 0 deletions test/parallel/test-worker-prof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
'use strict';
const common = require('../common');
const tmpdir = require('../common/tmpdir');
const fs = require('fs');
const assert = require('assert');
const { spawnSync } = require('child_process');
const { Worker } = require('worker_threads');

if (!common.isMainThread)
common.skip('process.chdir is not available in Workers');

// Test that --prof also tracks Worker threads.
// Refs: https://github.com/nodejs/node/issues/24016

if (process.argv[2] === 'child') {
const spin = `
const start = Date.now();
while (Date.now() - start < 200);
Comment thread
addaleax marked this conversation as resolved.
`;
new Worker(spin, { eval: true });
eval(spin);
return;
}

tmpdir.refresh();
process.chdir(tmpdir.path);
spawnSync(process.execPath, ['--prof', __filename, 'child']);
const logfiles = fs.readdirSync('.').filter((name) => /\.log$/.test(name));
assert.strictEqual(logfiles.length, 2); // Parent thread + child thread.

for (const logfile of logfiles) {
const lines = fs.readFileSync(logfile, 'utf8').split('\n');
const ticks = lines.filter((line) => /^tick,/.test(line)).length;

// Test that at least 20 ticks have been recorded for both parent and child
// threads. When not tracking Worker threads, only 1 or 2 ticks would
// have been recorded.
// When running locally on x64 Linux, this number is usually at least 150
// for both threads, so 15 seems like a very safe threshold.
assert(ticks >= 15, `${ticks} >= 15`);
}