Skip to content

process: start coverage collection before bootstrap #26006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 4 commits into from
Closed

process: start coverage collection before bootstrap #26006

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc2d5e9
process: start coverage collection before bootstrap
joyeecheung Feb 8, 2019
0bf9ae9
fixup! process: start coverage collection before bootstrap
joyeecheung Feb 8, 2019
44ff18b
fixup! fixup! process: start coverage collection before bootstrap
joyeecheung Feb 8, 2019
de2845b
fixup! fixup! fixup! process: start coverage collection before bootstrap
joyeecheung Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! fixup! process: start coverage collection before bootstrap
  • Loading branch information
@joyeecheung
joyeecheung committed Feb 18, 2019
commit de2845b25dab839bbafc0dd1255afd0ee9e6b51d
10 changes: 8 additions & 2 deletions src/node_binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
#define NODE_BUILTIN_REPORT_MODULES(V)
#endif

#if HAVE_INSPECTOR
#define NODE_BUILTIN_COVERAGE_MODULES(V) V(coverage)
#else
#define NODE_BUILTIN_COVERAGE_MODULES(V)
#endif

// A list of built-in modules. In order to do module registration
// in node::Init(), need to add built-in modules in the following list.
// Then in binding::RegisterBuiltinModules(), it calls modules' registration
Expand All @@ -33,7 +39,6 @@
V(cares_wrap) \
V(config) \
V(contextify) \
V(coverage) \
V(credentials) \
V(domain) \
V(fs) \
Expand Down Expand Up @@ -78,7 +83,8 @@
NODE_BUILTIN_STANDARD_MODULES(V) \
NODE_BUILTIN_OPENSSL_MODULES(V) \
NODE_BUILTIN_ICU_MODULES(V) \
NODE_BUILTIN_REPORT_MODULES(V)
NODE_BUILTIN_REPORT_MODULES(V) \
NODE_BUILTIN_COVERAGE_MODULES(V)

// This is used to load built-in modules. Instead of using
// __attribute__((constructor)), we call the _register_<modname>
Expand Down