Skip to content

build,win: configuration tweaks for faster build with MSVC #25931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refack merged 7 commits into from
Feb 14, 2019
Merged

build,win: configuration tweaks for faster build with MSVC #25931

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
20a917c
build: move optimizing link directives to node.exe target
refack Feb 3, 2019
82b7989
build,tools: add more headers to V8 PCH file
refack Feb 3, 2019
cd5c7bf
build,deps: use PCH also for v8_initializers
refack Feb 3, 2019
4698757
build,deps: remove cygwin configuration which is not supported
refack Feb 3, 2019
6ac80f0
build,src: add PCH to node.gypi
refack Oct 13, 2018
ff4adab
build,win: always build with PCH
refack Feb 4, 2019
2ffd20b
build,win: emit MSBuild summary
refack Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build,deps: use PCH also for v8_initializers 
* rename files to represent reuse

PR-URL: #25931
Reviewed-By: João Reis <reis@janeasystems.com>
  • Loading branch information
@refack
refack committed Feb 14, 2019
commit cd5c7bf240f92d2a5007f1e0de1dfc76d54222fd
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.11',
'v8_embedder_string': '-node.12',

##### V8 defaults for Node.js #####

Expand Down
23 changes: 14 additions & 9 deletions deps/v8/gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@
'dependencies': [
'v8_base',
],
'variables': {
'variables': {
'optimize': 'max',
},
'include_dirs': [
Expand Down Expand Up @@ -359,16 +359,20 @@
}],
# Platforms that don't have Compare-And-Swap support need to link atomic
# library to implement atomic memory access
[ 'v8_current_cpu == "mips" or v8_current_cpu == "mipsel" or '
'v8_current_cpu == "mips64" or v8_current_cpu == "mips64el" or '
'v8_current_cpu == "ppc" or v8_current_cpu == "ppc64" or '
'v8_current_cpu == "s390" or v8_current_cpu == "s390x"',
{
[ 'v8_current_cpu in ["mips", "mipsel", "mips64", "mips64el", "ppc", "ppc64", "s390", "s390x"]', {
'link_settings': {
'libraries': [ '-latomic', ],
},
},
],
['OS=="win" and node_use_pch == "true"', {
'msvs_precompiled_header': '../../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '../../../tools/msvs/pch/v8_pch.cc',
'sources': [
'<(_msvs_precompiled_header)',
'<(_msvs_precompiled_source)',
],
}],
],
}, # v8_initializers
{
Expand Down Expand Up @@ -1942,10 +1946,11 @@
# See http://crbug.com/485155.
'msvs_shard': 4,
}, {
'msvs_precompiled_header': 'tools/msvs/pch/pch_v8_base.h',
'msvs_precompiled_source': '../../../tools/msvs/pch/pch_v8_base.cc',
'msvs_precompiled_header': '../../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '../../../tools/msvs/pch/v8_pch.cc',
'sources': [
'../../../tools/msvs/pch/pch_v8_base.cc',
'<(_msvs_precompiled_header)',
'<(_msvs_precompiled_source)',
],
}],
],
Expand Down
1 change: 0 additions & 1 deletion tools/msvs/pch/pch_v8_base.cc
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions tools/msvs/pch/v8_pch.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "v8_pch.h"
0 tools/msvs/pch/pch_v8_base.h → tools/msvs/pch/v8_pch.h
View file
Open in desktop
File renamed without changes.