Skip to content

src: use visibility("default") for exports on POSIX #25893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

src: use visibility("default") for exports on POSIX #25893

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56b04ce
src: use `visibility("default")` for exports on POSIX
nornagon Oct 15, 2018
79591b0
fixup! src: use `visibility("default")` for exports on POSIX
addaleax Feb 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: use visibility("default") for exports on POSIX 
Electron uses this because Chromium builds with symbols
hidden by default.

Refs: electron/node@88b4941
Refs: electron/node@1293d1d
  • Loading branch information
@nornagon @addaleax
nornagon authored and addaleax committed Feb 2, 2019
commit 56b04ce046924f1196bd64287953f426a4b1b2b2
2 changes: 1 addition & 1 deletion src/js_native_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#ifdef _WIN32
#define NAPI_EXTERN __declspec(dllexport)
#else
#define NAPI_EXTERN /* nothing */
#define NODE_EXTERN __attribute__((visibility("default")))
Comment thread
addaleax marked this conversation as resolved.
Outdated
#endif
#endif

Expand Down
2 changes: 1 addition & 1 deletion src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
# define NODE_EXTERN __declspec(dllimport)
# endif
#else
# define NODE_EXTERN /* nothing */
# define NODE_EXTERN __attribute__((visibility("default")))
#endif

#ifdef BUILDING_NODE_EXTENSION
Expand Down