Skip to content

deps: update V8 to 7.3 #25852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 20 commits into from
Closed

deps: update V8 to 7.3 #25852

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
08b6ea8
deps: update V8 to 7.3.492.25
targos Mar 12, 2019
532fde3
build: reset embedder string to "-node.0"
targos Mar 12, 2019
4aec0fb
src: update NODE_MODULE_VERSION to 71
targos Mar 12, 2019
e590cfd
deps: sync V8 gypfiles with 7.2
targos Oct 10, 2018
eba8077
deps: sync V8 gypfiles with 7.3
ryzokuken Nov 30, 2018
b53dbc6
deps: cherry-pick fc0ddf5 from upstream V8
addaleax Jan 24, 2019
10f045d
deps: V8: cherry-pick 74571c8
targos Mar 4, 2019
56a7d4a
deps: V8: cherry-pick d3308d0
targos Mar 4, 2019
83bfa30
deps: v8, backport 2d08967
bcoe Feb 27, 2019
acc1f15
deps: V8: cherry-pick 58cefed
jkunkee Mar 7, 2019
f39bc38
deps: V8: cherry-pick 7803fa6
jkunkee Mar 7, 2019
02bb947
build,win: mark x86 image as not SAFESEH
refack Feb 2, 2019
6b3db85
build,deps: fix V8 snapshot gyp dependencies
refack Mar 10, 2019
6107f99
deps: silence irrelevant V8 warnings
targos Mar 13, 2019
80217cb
build,deps: add `NOMINMAX` to V8 Windows builds
refack Mar 13, 2019
80b5ab1
deps: bump minimum icu version to 63
ryzokuken Nov 8, 2018
eb2fa09
test: remove apply calls over 65534 arg limit
psmarshall Nov 22, 2018
55f195a
test: update test-v8-stats
targos Nov 23, 2018
4b9c461
test: fix tests after V8 update
targos Jan 18, 2019
c298cfa
test: update postmortem metadata test for V8 7.3
cjihrig Dec 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: update postmortem metadata test for V8 7.3 
The V8 7.3 update requires the following adjustments to the
postmortem debugging metadata constants:

- v8dbg_prop_idx_first was removed in
  v8/v8@1ad0cd5

- v8dbg_jsarray_buffer_was_neutered_mask was renamed to
  v8dbg_jsarray_buffer_was_detached_mask in
  v8/v8@f68ee6e

- v8dbg_jsarray_buffer_was_neutered_shift was renamed to
  v8dbg_jsarray_buffer_was_detached_shift in
  v8/v8@f68ee6e

- v8dbg_class_Map__instance_descriptors__DescriptorArray moved to
  v8dbg_class_Map__raw_instance_descriptors__DescriptorArray and
  began using ACCESSORS2 in
  v8/v8@799dfad

The following postmortem debugging constants were also impacted
by V8's introduction of ACCESSORS2, but do not need to be updated
the test:

- v8dbg_class_ThinString__actual__String changed in
  v8/v8@0f581e4

- v8dbg_class_UncompiledData__inferred_name__String changed in
  v8/v8@0f581e4

- v8dbg_class_JSFunction__shared__SharedFunctionInfo changed in
  v8/v8@8162090

- v8dbg_class_SharedFunctionInfo__function_data__Object had its
  accessor removed in
  v8/v8@a55803a
  This has been fixed in gen-postmortem-metadata.py.
  • Loading branch information
@cjihrig @targos
cjihrig authored and targos committed Mar 14, 2019
commit c298cfa835265610d99dbd1bc3b5aeb02d9542e5
7 changes: 3 additions & 4 deletions test/v8-updates/test-postmortem-metadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ function getExpectedSymbols() {
'v8dbg_class_Map__constructor_or_backpointer__Object',
'v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char',
'v8dbg_class_Map__instance_type__uint16_t',
'v8dbg_class_Map__instance_descriptors__DescriptorArray',
'v8dbg_class_Map__raw_instance_descriptors__DescriptorArray',
'v8dbg_class_Map__instance_size_in_words__char',
'v8dbg_class_Oddball__kind_offset__int',
'v8dbg_class_Script__line_ends__Object',
Expand Down Expand Up @@ -116,8 +116,8 @@ function getExpectedSymbols() {
'v8dbg_frametype_InternalFrame',
'v8dbg_frametype_OptimizedFrame',
'v8dbg_frametype_StubFrame',
'v8dbg_jsarray_buffer_was_neutered_mask',
'v8dbg_jsarray_buffer_was_neutered_shift',
'v8dbg_jsarray_buffer_was_detached_mask',
'v8dbg_jsarray_buffer_was_detached_shift',
'v8dbg_namedictionary_prefix_start_index',
'v8dbg_namedictionaryshape_entry_size',
'v8dbg_namedictionaryshape_prefix_size',
Expand All @@ -134,7 +134,6 @@ function getExpectedSymbols() {
'v8dbg_prop_desc_key',
'v8dbg_prop_desc_size',
'v8dbg_prop_desc_value',
'v8dbg_prop_idx_first',
'v8dbg_prop_index_mask',
'v8dbg_prop_index_shift',
'v8dbg_prop_kind_mask',
Expand Down