Skip to content

meta: clarify EoL platform support #25838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaocgreis wants to merge 3 commits into from
Closed

meta: clarify EoL platform support #25838

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08dc223
meta: clarify EoL platform support
joaocgreis Jan 30, 2019
652d105
fixup! meta: clarify EoL platform support
joaocgreis Jan 31, 2019
18c9847
fixup! meta: clarify EoL platform support
joaocgreis Feb 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! meta: clarify EoL platform support
  • Loading branch information
@joaocgreis
joaocgreis committed Jan 31, 2019
commit 652d105632c28d6943dc3804594c90f27cd21d1b
5 changes: 3 additions & 2 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,9 @@ There are three support tiers:

For production applications, run Node.js on supported platforms only.

Note that end-of-life (EoL) platforms are not supported even if listed below
and can be removed at any moment.
End-of-life (EoL) platforms are not supported even if listed below and can be
Copy link
Copy Markdown
Member

@Trott Trott Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
End-of-life (EoL) platforms are not supported even if listed below and can be
End-of-life (EoL) platforms are not supported, even if listed below, and can be

removed at any moment. The community does not build or test against EoL
Copy link
Copy Markdown
Member

@mhdawson mhdawson Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be slightly concerned that this could be read as that we "can't" even if it's what we think need to be the case for some period of time. How about "The community avoids building or testing against EoL platforms"

Copy link
Copy Markdown
Member

@Trott Trott Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
removed at any moment. The community does not build or test against EoL
removed at any time. The community does not build or test against EoL

platforms.

| System | Support type | Version | Architectures | Notes |
| ------------ | ------------ | ------------------------------- | ---------------- | ----------------------------- |
Expand Down