Skip to content

test: use tmpDir instead of fixturesDir #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thefourtheye wants to merge 2 commits into from
Closed

test: use tmpDir instead of fixturesDir #2583

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5497f4c
test: use tmpDir instead of fixturesDir
thefourtheye Aug 27, 2015
14d0206
Moving to parallel
thefourtheye Aug 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: use tmpDir instead of fixturesDir 
This test was using fixturesDir to create temp files to test. This
patch replaces that with tmpDir and uses `assert` module to test.
  • Loading branch information
@thefourtheye
thefourtheye committed Aug 27, 2015
commit 5497f4ce1552174b623dea17c9425f1d1298907d
45 changes: 15 additions & 30 deletions test/sequential/test-regress-GH-3739.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,31 @@
'use strict';
var common = require('../common'),
assert = require('assert'),
fs = require('fs'),
path = require('path');

var dir = path.resolve(common.fixturesDir),
dirs = [];
const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const path = require('path');

var dir = path.resolve(common.tmpDir);

// Make sure that the tmp directory is clean
common.refreshTmpDir();

// Make a long path.
for (var i = 0; i < 50; i++) {
dir = dir + '/123456790';
dir = dir + '/1234567890';
try {
fs.mkdirSync(dir, '0777');
} catch (e) {
if (e.code == 'EEXIST') {
// Ignore;
} else {
cleanup();
if (e.code !== 'EEXIST') {
throw e;
}
}
dirs.push(dir);
}

// Test existsSync
var r = common.fileExists(dir);
if (r !== true) {
cleanup();
throw new Error('fs.accessSync returned false');
}
// Test if file exists synchronously
assert(common.fileExists(dir), 'Directory is not accessible');

// Text exists
// Test if file exists asynchronously
fs.access(dir, function(err) {
cleanup();
if (err) {
throw new Error('fs.access reported false');
}
assert(!err, 'Directory is not accessible');
});

// Remove all created directories
function cleanup() {
for (var i = dirs.length - 1; i >= 0; i--) {
fs.rmdirSync(dirs[i]);
}
}