windows: disable exceptions properly - #258
Merged
Merged
Conversation
Member
|
LGTM |
Previously exception handling was disabled in release builds, but enabled in debug builds. That makes no sense. PR-URL: nodejs#258 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Tell the stl that exception handling is unavailable. This avoids warnings like: C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\ xlocale(337): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc PR-URL: nodejs#258 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus
force-pushed
the
no-exceptions
branch
from
January 8, 2015 10:42
eae25f1 to
4519db0
Compare
Member
|
👍 |
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Aug 29, 2026
joyeecheung
pushed a commit
that referenced
this pull request
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.