Skip to content

module: do not use process.exit() #25769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

module: do not use process.exit() #25769

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fc4d51
module: silence ModuleJob unhandled rejection warnings
addaleax Jan 28, 2019
301351c
module: do not use `process.exit()`
addaleax Jan 28, 2019
e941f85
squash! module: do not use `process.exit()`
addaleax Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
module: silence ModuleJob unhandled rejection warnings 
This could otherwise print unhandled rejection warnings
if the process does not exit immediately inside an earlier
`.catch()` handler.
  • Loading branch information
@addaleax
addaleax committed Jan 28, 2019
commit 7fc4d513b4d96e332f6a06efcd1fd7da9228e61f
5 changes: 5 additions & 0 deletions lib/internal/modules/esm/module_job.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ const { decorateErrorStack } = require('internal/util');
const assert = require('assert');
const resolvedPromise = SafePromise.resolve();

function noop() {}

/* A ModuleJob tracks the loading of a single Module, and the ModuleJobs of
* its dependencies, over time. */
class ModuleJob {
Expand Down Expand Up @@ -41,6 +43,9 @@ class ModuleJob {
};
// Promise for the list of all dependencyJobs.
this.linked = link();
// This promise is awaited later anyway, so silence
// 'unhandled rejection' warnings.
this.linked.catch(noop);

// instantiated == deep dependency jobs wrappers instantiated,
// module wrapper instantiated
Expand Down