Skip to content

test: replace Google servers with localhost #25694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: replace Google servers with localhost #25694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: replace Google servers with localhost 
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: #25664
  • Loading branch information
@Trott
Trott committed Jan 25, 2019
commit 472dfc15f91a5632fd76f6b0487c8fb09361e6e8
9 changes: 3 additions & 6 deletions test/parallel/test-dns-setserver-when-querying.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ const common = require('../common');

const dns = require('dns');

const goog = [
'8.8.8.8',
'8.8.4.4',
];
const localhost = [ '127.0.0.1' ];

{
// Fix https://github.com/nodejs/node/issues/14734
Expand All @@ -16,7 +13,7 @@ const goog = [
const resolver = new dns.Resolver();
resolver.resolve('localhost', common.mustCall());

common.expectsError(resolver.setServers.bind(resolver, goog), {
common.expectsError(resolver.setServers.bind(resolver, localhost), {
code: 'ERR_DNS_SET_SERVERS_FAILED',
message: /^c-ares failed to set servers: "There are pending queries\." \[.+\]$/g
});
Expand All @@ -26,6 +23,6 @@ const goog = [
dns.resolve('localhost', common.mustCall());

// should not throw
dns.setServers(goog);
dns.setServers(localhost);
}
}