Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! test: assert on client and server side seperately
  • Loading branch information
sam-github committed Jan 24, 2019
commit 6fe20ec2a80f5210ae46cf308b36b1e2e09b4b5c
17 changes: 17 additions & 0 deletions test/parallel/test-tls-min-max-version.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,23 @@ function test(cmin, cmax, cprot, smin, smax, sprot, proto, cerr, serr) {
if (!proto) {
console.log('client', pair.client.err ? pair.client.err.code : undefined);
console.log('server', pair.server.err ? pair.server.err.code : undefined);
// 11.x doesn't have https://github.com/nodejs/node/pull/24729
if (cerr === 'ERR_TLS_INVALID_PROTOCOL_METHOD' &&
pair.client.err &&
pair.client.err.message.includes('methods disabled'))
pair.client.err.code = 'ERR_TLS_INVALID_PROTOCOL_METHOD';
if (serr === 'ERR_TLS_INVALID_PROTOCOL_METHOD' &&
pair.server.err &&
pair.server.err.message.includes('methods disabled'))
pair.server.err.code = 'ERR_TLS_INVALID_PROTOCOL_METHOD';
if (cerr === 'ERR_TLS_INVALID_PROTOCOL_METHOD' &&
pair.client.err &&
pair.client.err.message.includes('Unknown method'))
pair.client.err.code = 'ERR_TLS_INVALID_PROTOCOL_METHOD';
if (serr === 'ERR_TLS_INVALID_PROTOCOL_METHOD' &&
pair.server.err &&
pair.server.err.message.includes('Unknown method'))
pair.server.err.code = 'ERR_TLS_INVALID_PROTOCOL_METHOD';
if (cerr) {
assert(pair.client.err);
// Accept these codes as aliases, the one reported depends on the
Expand Down