Skip to content

test: enable marking of failing coverage tests #25671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 6 commits into from
Closed

test: enable marking of failing coverage tests #25671

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a45db5
test: enable marking of failing coverage tests
mhdawson Jan 22, 2019
58013ef
squash: allow FAIL and CRASH to avoid yellow
mhdawson Jan 23, 2019
9d0c898
squash: allow new tests to pass until ci job added
mhdawson Jan 23, 2019
c27dd17
squash: address comments
mhdawson Jan 24, 2019
a48bc9f
squash: address comments
mhdawson Jan 24, 2019
f7b5b67
squash: address comments
mhdawson Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: allow FAIL and CRASH to avoid yellow 
Allow FAIL and CRASH to avoid yellow, otherwise
if we added to regular CI run we'd have perma-yellow
  • Loading branch information
@mhdawson
mhdawson committed Jan 23, 2019
commit 58013ef5b628315e0a1a79cbd23b10403fa6157c
4 changes: 2 additions & 2 deletions test/js-native-api/js-native-api.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ prefix js-native-api
[$system==aix]

[$type==coverage]
test_function/test: PASS,FLAKY
test_general/testFinalizer: PASS,FLAKY
test_function/test: PASS,FAIL,CRASH
Copy link
Copy Markdown
Contributor

@bcoe bcoe Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach to isolating flaky tests a lot 👍 first saw it in the blink codebase.

Copy link
Copy Markdown
Contributor

@refack refack Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might consider putting this in https://github.com/nodejs/node/blob/master/test/root.status
My intuition is that file fit better to represent this is a cross-cutting concern.

Copy link
Copy Markdown
Member Author

@mhdawson mhdawson Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You learn something new every day. I was not aware of that option. I like having the list in one place so will move there.

test_general/testFinalizer: PASS,FAIL,CRASH