Skip to content

report: do not use uv_default_loop() as fallback #25652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

report: do not use uv_default_loop() as fallback #25652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
report: do not use uv_default_loop() as fallback 
Not seeing an associated `Environment` is a rare condition anyway,
but using `uv_default_loop()` as a fallback is not thread-safe.
  • Loading branch information
@addaleax
addaleax committed Jan 24, 2019
commit 0542913603ab44a5c623eff85c566f85c4a77c74
2 changes: 0 additions & 2 deletions src/node_report.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,6 @@ static void WriteNodeReport(Isolate* isolate,
writer.json_arraystart("libuv");
if (env != nullptr)
uv_walk(env->event_loop(), WalkHandle, static_cast<void*>(&writer));
else
uv_walk(uv_default_loop(), WalkHandle, static_cast<void*>(&writer));
Copy link
Copy Markdown
Member

@richardlau richardlau Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the report is meant to aid diagnostics, is there any value in logging that env was null in the report?

Copy link
Copy Markdown
Member Author

@addaleax addaleax Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau I guess we could do that – do you have any suggestion on how to represent that?


writer.json_arrayend();

Expand Down