Skip to content

build,python: update flake8 rules #25614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refack merged 3 commits into from
Apr 14, 2019
Merged

build,python: update flake8 rules #25614

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0befda6
tools: python: update flake8 rules
refack Apr 11, 2019
a16a0fe
tools: python: activate more flake8 rules
refack Apr 13, 2019
1fc4255
tools: python: ignore instead of select flake8 rules
refack Apr 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: python: activate more flake8 rules 
PR-URL: #25614
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
@refack
refack committed Apr 14, 2019
commit a16a0fe9629325ae1dd81827c6071ca972d7449a
2 changes: 1 addition & 1 deletion .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[flake8]
exclude=.git,deps,lib,src,tools/gyp,tools/inspector_protocol,tools/pip,tools/v8_gypfiles/broken
select=E9,F82
select=E9,F63,F72,F82
2 changes: 1 addition & 1 deletion tools/configure.d/nodedownload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def parse(opt):
if not anOpt or anOpt == "":
# ignore stray commas, etc.
continue
elif anOpt is 'all':
elif anOpt == 'all':
# all on
theRet = dict((key, True) for (key) in download_types)
else:
Expand Down
6 changes: 3 additions & 3 deletions tools/icu/icutrim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
print("Unknown endianness: %s" % options.endian)
sys.exit(1)

if options.endian is "host":
if options.endian == "host":
options.endian = endian

if not os.path.isdir(options.tmpdir):
Expand Down Expand Up @@ -153,7 +153,7 @@ def runcmd(tool, cmd, doContinue=False):
print("# " + cmd)

rc = os.system(cmd)
if rc is not 0 and not doContinue:
if rc != 0 and not doContinue:
print("FAILED: %s" % cmd)
sys.exit(1)
return rc
Expand Down Expand Up @@ -320,7 +320,7 @@ def removeList(count=0):
print(i, file=fi)
fi.close()
rc = runcmd("icupkg","-r %s %s 2> %s" % (removefile,outfile,hackerrfile),True)
if rc is not 0:
if rc != 0:
if(options.verbose>5):
print("## Damage control, trying to parse stderr from icupkg..")
fi = open(hackerrfile, 'rb')
Expand Down
3 changes: 2 additions & 1 deletion tools/js2c.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ def ReadMacros(lines):
hash = line.find('#')
if hash != -1: line = line[:hash]
line = line.strip()
if len(line) is 0: continue
if len(line) == 0:
continue
const_match = CONST_PATTERN.match(line)
if const_match:
name = const_match.group(1)
Expand Down
4 changes: 2 additions & 2 deletions tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ def HasRun(self, output):
logger.info(' ---')
logger.info(' duration_ms: %d.%d' %
(total_seconds, duration.microseconds / 1000))
if self.severity is not 'ok' or self.traceback is not '':
if self.severity != 'ok' or self.traceback != '':
if output.HasTimedOut():
self.traceback = 'timeout\n' + output.output.stdout + output.output.stderr
self._printDiagnostic()
Expand Down Expand Up @@ -1641,7 +1641,7 @@ def Main():
continue
archEngineContext = Execute([vm, "-p", "process.arch"], context)
vmArch = archEngineContext.stdout.rstrip()
if archEngineContext.exit_code is not 0 or vmArch == "undefined":
if archEngineContext.exit_code != 0 or vmArch == "undefined":
print("Can't determine the arch of: '%s'" % vm)
print(archEngineContext.stderr.rstrip())
continue
Expand Down