Skip to content

http2: allow fully synchronous _final() #25609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

http2: allow fully synchronous _final() #25609

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90fbe14
http2: allow fully synchronous `_final()`
addaleax Jan 21, 2019
66fdcc1
fixup! http2: allow fully synchronous `_final()`
addaleax Jan 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! http2: allow fully synchronous _final()
  • Loading branch information
@addaleax
addaleax committed Jan 21, 2019
commit 66fdcc1da70673c4cc5da42eeacfdd033e3c5102
2 changes: 1 addition & 1 deletion src/stream_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ class StreamResource {

// Perform a shutdown operation, and either call req_wrap->Done() when
// finished and return 0, return 1 for synchronous success, or
// a libuv errr code for synchronous failures.
// a libuv error code for synchronous failures.
virtual int DoShutdown(ShutdownWrap* req_wrap) = 0;
// Try to write as much data as possible synchronously, and modify
// `*bufs` and `*count` accordingly. This is a no-op by default.
Expand Down