Skip to content

report: misc cleanup #25597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 5 commits into from
Jan 22, 2019
Merged

report: misc cleanup #25597

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad2b42e
report: remove unnecessary intermediate variable
cjihrig Jan 20, 2019
04c9f84
report: remove unnecessary includes
cjihrig Jan 20, 2019
5003314
report: use uv_pid_t instead of custom PID_TYPE
cjihrig Jan 20, 2019
a022337
report: simplify option checking
cjihrig Jan 20, 2019
1ef175e
report: simplify rlimit to JSON logic
cjihrig Jan 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
report: remove unnecessary intermediate variable 
PR-URL: #25597
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
  • Loading branch information
@cjihrig
cjihrig committed Jan 22, 2019
commit ad2b42e3b6def7d01fdbb7ed5ea013305ed7df41
3 changes: 1 addition & 2 deletions src/node_report_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,7 @@ void WalkHandle(uv_handle_t* h, void* arg) {
if (h->type == UV_TCP || h->type == UV_NAMED_PIPE || h->type == UV_TTY ||
h->type == UV_UDP || h->type == UV_POLL) {
uv_os_fd_t fd_v;
uv_os_fd_t* fd = &fd_v;
int rc = uv_fileno(h, fd);
int rc = uv_fileno(h, &fd_v);
// uv_os_fd_t is an int on Unix and HANDLE on Windows.
#ifndef _WIN32
if (rc == 0) {
Expand Down