Skip to content

WIP still fixing up [v10.x backport] n-api: handle reference delete before finalize #25572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 13 commits into from
Closed

WIP still fixing up [v10.x backport] n-api: handle reference delete before finalize #25572

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8810051
deps: cherry-pick 525b396 from V8 upstream
psmarshall Dec 14, 2018
3af7528
doc: update the http.request.setTimeout docs to be accurate
jbunton-atlassian Dec 19, 2018
48da8be
test: fix test-repl-envvars
addaleax Dec 26, 2018
64f232c
n-api: add API for asynchronous functions
Jun 17, 2018
ca8ba15
n-api: fix compiler warning
cjihrig Jun 29, 2018
7b68d89
n-api: guard against cond null dereference
Jul 18, 2018
c275534
src: fix may be uninitialized warning in n-api
mhdawson Jul 19, 2018
311e1f1
n-api: remove idle_running from TsFn
Jul 27, 2018
a0fa101
n-api: clean up thread-safe function
Aug 11, 2018
ffbfe34
doc: fix optional parameters in n-api.md
Sep 21, 2018
cffe85c
n-api: add missing handle scopes
danbev Oct 31, 2018
b44bd88
test: mark test_threadsafe_function/test as flaky
gireeshpunathil Nov 29, 2018
4f1aeb3
n-api: handle reference delete before finalize
mhdawson Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: update the http.request.setTimeout docs to be accurate 
Refs: #8895

PR-URL: #25123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@jbunton-atlassian @MylesBorins
jbunton-atlassian authored and MylesBorins committed Dec 26, 2018
commit 3af7528ac399e77eca40b2d00a39afb8dc935b95
5 changes: 3 additions & 2 deletions doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,8 +625,9 @@ added: v0.5.9
* `timeout` {number} Milliseconds before a request times out.
* `callback` {Function} Optional function to be called when a timeout occurs. Same as binding to the `timeout` event.

Once a socket is assigned to this request and is connected
[`socket.setTimeout()`][] will be called.
If no socket is assigned to this request then [`socket.setTimeout()`][] will be
called immediately. Otherwise [`socket.setTimeout()`][] will be called after the
assigned socket is connected.

Returns `request`.

Expand Down