Skip to content

doc: add note regarding pushing release tags #25569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 2 commits into from
Closed

doc: add note regarding pushing release tags #25569

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19982da
doc: add note regarding pushing release tags
MylesBorins Jan 18, 2019
d56e9a5
fix nits
MylesBorins Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion doc/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ install the new build. Make sure that the build appears correct. Check the
version numbers, and perform some basic checks to confirm that all is well with
the build before moving forward.

### 11. Tag and Sign the Release Commit
### 11. Tag and Sign the Release Commit
Comment thread
MylesBorins marked this conversation as resolved.
Outdated

Once you have produced builds that you're happy with, create a new tag. By
waiting until this stage to create tags, you can discard a proposed release if
Expand Down Expand Up @@ -473,6 +473,9 @@ following command:
$ git push <remote> <vx.y.z>
```

*Note*: Please do not push the tag unless you are ready to complete the remainder of the release
Comment thread
MylesBorins marked this conversation as resolved.
Outdated
steps 12 - 19
Comment thread
MylesBorins marked this conversation as resolved.
Outdated

### 12. Set Up For the Next Release

On release proposal branch, edit `src/node_version.h` again and:
Expand Down