Skip to content

dns: idna encode hostnames before resolution #25559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santigimeno wants to merge 4 commits into from
Closed

dns: idna encode hostnames before resolution #25559

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
973bab3
dns: idna encode hostnames before resolution
santigimeno Jan 18, 2019
37505d9
fixup
santigimeno Jan 18, 2019
7f05c44
be lenient on exceptions if using punycode toASCII
santigimeno Jan 18, 2019
79a2772
fix linting
santigimeno Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix linting
  • Loading branch information
@santigimeno
santigimeno committed Jan 18, 2019
commit 79a2772fc197d2da8e8a72199da4e1e07072af13
2 changes: 1 addition & 1 deletion lib/dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ function resolver(bindingName) {
try {
Copy link
Copy Markdown
Member

@saghul saghul Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be needed if we were only using the ICU based toASCII?

Copy link
Copy Markdown
Member Author

@santigimeno santigimeno Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is no

name = toASCII(name, true);
} catch {
// if using the punycode implementation, be lenient too
// If using the punycode implementation, be lenient too
}
var req = new QueryReqWrap();
req.bindingName = bindingName;
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/dns/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ function createResolverPromise(resolver, bindingName, hostname, ttl) {
try {
hostname = toASCII(hostname, true);
} catch {
// if using the punycode implementation, be lenient too
// If using the punycode implementation, be lenient too
}
const err = resolver._handle[bindingName](req, hostname);

Expand Down