Skip to content

test: ensure npm version is not release candidate #25538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 1 commit into from
Closed

test: ensure npm version is not release candidate #25538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: ensure npm version is not release candidate 
v11.6.0 ended up shipping with an npm version `6.5.0-next.0`.
This test should avoid it happening in the future.
  • Loading branch information
@MylesBorins
MylesBorins committed Jan 16, 2019
commit 134a8c548dfa708c23acef11aee984c5ee5a58d0
18 changes: 18 additions & 0 deletions test/parallel/test-npm-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';
require('../common');

const path = require('path');
const assert = require('assert');

const npmPathPackageJson = path.resolve(
__dirname,
'..',
'..',
'deps',
'npm',
'package.json'
);

const pkg = require(npmPathPackageJson);
assert(pkg.version.match(/^\d+\.\d+\.\d+$/),
Copy link
Copy Markdown
Member

@Trott Trott Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert(pkg.version.match(/^\d+\.\d+\.\d+$/),
assert.ok(/^\d+.\d+.\d+$/.test(pkg.version.match),

`unexpected version number: ${pkg.version}`);