Skip to content

test: do not assume tls handshake order #25508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-github wants to merge 11 commits into from
Closed

test: do not assume tls handshake order #25508

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
74f1db9
test: wait for TCP connect, not TLS handshake
sam-github Feb 1, 2019
6c13102
test: do not assume server gets secure connection
sam-github Feb 1, 2019
78565d7
test: do not assume tls handshake order
sam-github Jan 8, 2019
c523483
test: do not race connection and rejection
sam-github Jan 9, 2019
e981f20
test: pin regression test for #8074 to TLS 1.2
sam-github Jan 15, 2019
39327b2
test: end tls gracefully, rather than destroy
sam-github Feb 1, 2019
79412a4
test: send a bad record only after connection done
sam-github Feb 1, 2019
431fd20
test: use mustCall in ephemeralkeyinfo test
sam-github Feb 1, 2019
55e0809
test: use common.mustCall(), and log the events
sam-github Feb 1, 2019
3dab493
test: use mustCall(), not global state checks
sam-github Feb 1, 2019
619b034
test: clarify confusion over "client" in comment
sam-github Feb 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: pin regression test for #8074 to TLS 1.2 
This test has a dependency on the order in which the TCP connection is
made, and TLS server handshake completes. It assumes those server side
events occur before the client side write callback, which is not
guaranteed by the TLS API. It usually passes with TLS1.3, but TLS1.3
didn't exist at the time the bug existed.

Pin the test to TLS1.2, since the test shouldn't be changed in a way that
doesn't trigger a segfault in 7.7.3:
- #13184 (comment)
  • Loading branch information
@sam-github
sam-github committed Feb 5, 2019
commit e981f202bfc42f83255ee297bda9259293636382
13 changes: 13 additions & 0 deletions test/parallel/test-tls-socket-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,19 @@ const tls = require('tls');
const net = require('net');
const fixtures = require('../common/fixtures');

// Regression test for https://github.com/nodejs/node/issues/8074
//
// This test has a dependency on the order in which the TCP connection is made,
// and TLS server handshake completes. It assumes those server side events occur
// before the client side write callback, which is not guaranteed by the TLS
// API. It usally passes with TLS1.3, but TLS1.3 didn't exist at the time the
// bug existed.
//
// Pin the test to TLS1.2, since the test shouldn't be changed in a way that
// doesn't trigger a segfault in Node.js 7.7.3:
// https://github.com/nodejs/node/issues/13184#issuecomment-303700377
tls.DEFAULT_MAX_VERSION = 'TLSv1.2';

const key = fixtures.readKey('agent2-key.pem');
const cert = fixtures.readKey('agent2-cert.pem');

Expand Down