Skip to content

[v11.x] src: move more process methods initialization in bootstrap/node.js #25496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 8 commits into from
Closed

[v11.x] src: move more process methods initialization in bootstrap/node.js #25496

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
427839e
src: move more process methods initialization in bootstrap/node.js
joyeecheung Dec 19, 2018
5b780eb
src: fix compiler warnings
cjihrig Dec 21, 2018
172466c
coverage: use process._rawDebug() during setup
cjihrig Dec 31, 2018
dcd7767
coverage: pass cwd to path.resolve() in setup
cjihrig Dec 31, 2018
066985a
test: make test-v8-coverage.js more strict
cjihrig Dec 31, 2018
5771dc4
util: fixes type in argument type validation error
aoberoi Dec 18, 2018
7dffd82
src: move node::errno_string into node_errors.h/cc
joyeecheung Jan 8, 2019
7bf10e3
test: add test for fs.lchmod
ZYSzys Jan 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
coverage: use process._rawDebug() during setup 
console is not ready to use at this point in the bootstrapping
process, so switch to process._rawDebug() instead.

PR-URL: #25289
Fixes: #25287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@cjihrig @addaleax
cjihrig authored and addaleax committed Jan 14, 2019
commit 172466cfde90bb66700ba0a10c30b92b8478a925
4 changes: 2 additions & 2 deletions lib/internal/process/coverage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ exports.writeCoverage = writeCoverage;
function setup() {
const { Connection } = internalBinding('inspector');
if (!Connection) {
console.warn('inspector not enabled');
process._rawDebug('inspector not enabled');
return;
}

Expand All @@ -80,7 +80,7 @@ function setup() {
coverageDirectory = process.env.NODE_V8_COVERAGE =
resolve(process.env.NODE_V8_COVERAGE);
} catch (err) {
console.error(err);
process._rawDebug(err.toString());
}
}

Expand Down