Skip to content

os: add fallback for undefined CPUs #25493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JungMinu wants to merge 1 commit into from
Closed

os: add fallback for undefined CPUs #25493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
os: add fallback for undefined CPUs 
For an unsupported OS, a call to os.cpus() throws an error
within os.cpus() itself where it tries to get the length of it.
This fixes the issue by adding fallback for undefined CPUs.

Fixes: #25483
PR-URL: #25493
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@JungMinu
JungMinu committed Jan 16, 2019
commit 02a5dafdbb823f38f811db538ea3d1db2d442238
3 changes: 2 additions & 1 deletion lib/os.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ function loadavg() {
}

function cpus() {
const data = getCPUs();
// [] is a bugfix for a regression introduced in 51cea61
const data = getCPUs() || [];
Comment thread
JungMinu marked this conversation as resolved.
Outdated
const result = [];
for (var i = 0; i < data.length; i += 7) {
result.push({
Expand Down