Skip to content

[v8.x] http: attach reused parser to correct domain #25459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
misterdjules wants to merge 3 commits into from
Closed

[v8.x] http: attach reused parser to correct domain #25459

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdcb150
http: attach reused parser to correct domain
Jan 11, 2019
c1004ad
changes according to latest code review
Jan 14, 2019
2e459d0
get rid of dead code
Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
get rid of dead code
  • Loading branch information
Julien Gilli committed Jan 14, 2019
commit 2e459d0ce74420542ee773520bca18f6a554418a
1 change: 0 additions & 1 deletion test/parallel/test-http-parser-reuse-domain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ function performHttpRequest(opts, cb) {

function performHttpRequestInNewDomain(opts, cb) {
const d = domain.create();
d._id = opts.id;
d.run(() => {
performHttpRequest(opts, cb);
});
Expand Down