Skip to content

[11.x] use NativeModuleLoader to compile all the bootstrappers #25446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 28 commits into from
Closed

[11.x] use NativeModuleLoader to compile all the bootstrappers #25446

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
617bfe4
lib: remove internalBinding('config').pendingDeprecation
joyeecheung Dec 11, 2018
c168672
inspector: move process.binding to internalBinding
BeniCheni Dec 10, 2018
dc4e5c5
util: inspect ArrayBuffers contents as well
BridgeAR Dec 13, 2018
0c67a51
lib: remove internal `util._extends()` usage
BridgeAR Dec 18, 2018
e97acf7
lib: expose all type checks from the internal types module
BridgeAR Dec 20, 2018
95fa3c7
buffer: inspect extra properties
BridgeAR Dec 20, 2018
7ff4402
lib: move lib/console.js to lib/internal/console/constructor.js
joyeecheung Nov 28, 2018
2f1f009
console: split console into global.js and constructor.js
joyeecheung Nov 28, 2018
6280cda
console: move the inspector console wrapping in a separate file
joyeecheung Nov 28, 2018
6bf7511
console: add `inspectOptions` option
BridgeAR Dec 12, 2018
049b24d
console: improve inspectOptions validation
cjihrig Dec 17, 2018
8d166c9
process: provide dummy stdio for non-console Windows apps
addaleax May 9, 2018
c219b8f
Revert "lib: expose all type checks from the internal types module"
joyeecheung Jan 11, 2019
f4dbe57
Revert "inspector: move process.binding to internalBinding"
joyeecheung Jan 11, 2019
7aeec97
Revert "lib: remove internalBinding('config').pendingDeprecation"
joyeecheung Jan 11, 2019
48dfda7
Revert "os: move process.binding('os') to internalBinding"
joyeecheung Jan 11, 2019
abfde34
Revert "lib: remove unused NativeModule/NativeModule wraps"
joyeecheung Jan 11, 2019
c5b2c31
Revert "src,lib: make process.binding('config') internal"
joyeecheung Jan 11, 2019
fb6f2f2
Revert "lib: remove duplicated noop function"
joyeecheung Jan 11, 2019
106b299
fs: make process.binding('fs') internal
Aug 23, 2018
9a5984d
src: use NativeModuleLoader to compile all the bootstrappers
joyeecheung Nov 26, 2018
373bbe7
lib: remove duplicated noop function
ZYSzys Dec 1, 2018
b6afa46
src,lib: make process.binding('config') internal
Oct 8, 2018
5bc4592
lib: remove unused NativeModule/NativeModule wraps
joyeecheung Dec 8, 2018
e05e5b3
inspector: move process.binding to internalBinding
BeniCheni Dec 10, 2018
181d03a
os: move process.binding('os') to internalBinding
briete Dec 17, 2018
4cb9036
lib: remove internalBinding('config').pendingDeprecation
joyeecheung Dec 11, 2018
7d90f03
lib: expose all type checks from the internal types module
BridgeAR Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "lib: remove duplicated noop function" 
This reverts commit 1ec4f8d.
  • Loading branch information
@joyeecheung
joyeecheung committed Jan 11, 2019
commit fb6f2f214a84df41a1e5a4de399989b02f4fc9eb
1 change: 1 addition & 0 deletions lib/internal/bootstrap/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@
// so these are now deprecated non-ops that can be removed after one
// major release cycle.
if (process.platform === 'win32') {
function noop() {}
const names = [
'NET_SERVER_CONNECTION',
'NET_SERVER_CONNECTION_CLOSE',
Expand Down