Skip to content

test: fix and refactor test-fs-watch-non-recursive #25386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: fix and refactor test-fs-watch-non-recursive #25386

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2daeff0
test: fix test/pummel/test-fs-watch-non-recursive.js
Trott Jan 8, 2019
bcd34ac
test: refactor test-fs-watch-non-recursive
Trott Jan 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: refactor test-fs-watch-non-recursive 
The test was duplicating some functionality in the `tmpdir` module.
  • Loading branch information
@Trott
Trott committed Jan 8, 2019
commit bcd34ac1361590c8304feda7bc802a27ee6c435a
10 changes: 2 additions & 8 deletions test/pummel/test-fs-watch-non-recursive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,13 @@ const path = require('path');
const fs = require('fs');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

const testDir = tmpdir.path;
const testsubdir = path.join(testDir, 'testsubdir');
const filepath = path.join(testsubdir, 'watch.txt');

function cleanup() {
try { fs.unlinkSync(filepath); } catch { }
try { fs.rmdirSync(testsubdir); } catch { }
}
process.on('exit', cleanup);
cleanup();

try { fs.mkdirSync(testsubdir, 0o700); } catch {}
fs.mkdirSync(testsubdir, 0o700);

// Need a grace period, else the mkdirSync() above fires off an event.
setTimeout(function() {
Expand Down