Skip to content

src: remove unused isolate variable #25368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 1 commit into from
Closed

src: remove unused isolate variable #25368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: remove unused isolate variable 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.
  • Loading branch information
@danbev
danbev committed Jan 6, 2019
commit 5061bdf6f4b41ef28cbd28ddd9dffa62aad78c0a
1 change: 0 additions & 1 deletion src/node_task_queue.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ void PromiseRejectCallback(PromiseRejectMessage message) {
static void SetPromiseRejectCallback(
const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
Isolate* isolate = env->isolate();

CHECK(args[0]->IsFunction());
env->set_promise_reject_callback(args[0].As<Function>());
Expand Down