Skip to content

modules: significantly improve require performance #25362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 16 commits into from
Closed

modules: significantly improve require performance #25362

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bbfe4a3
benchmark: add new module loading benchmarks
BridgeAR Jan 2, 2019
9c54e43
modules: significantly improve repeated requires
BridgeAR Dec 30, 2018
23eee46
fixup: changed signature on master
BridgeAR Jan 6, 2019
ab5d408
fixup: add line back
BridgeAR Jan 6, 2019
f447111
fixup: typo
BridgeAR Jan 6, 2019
fc0493a
fixup: remove minor breaking change
BridgeAR Jan 6, 2019
e625fb8
fixup: remove obsolete internals check
BridgeAR Jan 6, 2019
c7a9751
fixup: add backwards compat fix
BridgeAR Jan 6, 2019
d8aca04
fixup: address long sentence
BridgeAR Jan 6, 2019
5de8e71
fixup: check internal modules first
BridgeAR Jan 6, 2019
ba9c391
fixup: try using an own object
BridgeAR Jan 6, 2019
34a1785
fixup: smaller code
BridgeAR Jan 6, 2019
554c5ac
fixup: faster internal check
BridgeAR Jan 6, 2019
38afefb
fixup: make sure extension symbols are ignored
BridgeAR Jan 6, 2019
7194285
fixup: keep backwards compatible return value
BridgeAR Jan 6, 2019
59116ac
fixup: improve benchmarks
BridgeAR Jan 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: check internal modules first
  • Loading branch information
@BridgeAR
BridgeAR committed Jan 6, 2019
commit 5de8e71e31f33c29037309e32e3d06f8a6d0870a
31 changes: 11 additions & 20 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,19 +444,21 @@ Module._resolveLookupPaths = function(request, parent) {
};

const filenameCache = Object.create(null);

// Check the cache for the requested file.
// 1. If a module already exists in the cache: return its exports object.
// 2. If the module is native: call `NativeModule.require()` with the
// filename and return the result.
// 3. Otherwise, create a new module for the file and save it to the cache.
// Then have it load the file contents before returning its exports
// object.
Module._load = function(request, parent, isMain) {
if (NativeModule.nonInternalExists(request)) {
// Check for native modules first. If we find such name in the user module
// cache, bail out. This keeps the behavior backwards compatible. It was
// originally meant to allow mocking of whole modules by placing a native
// module name in there.
if (Module._cache[request] !== undefined)
return Module._cache[request].exports;
debug('load native module %s', request);
return NativeModule.require(request);
}

let identifier;
if (parent !== undefined) {
debug('Module._load REQUEST %s parent: %s', request, parent.id);

// Fast path for (lazy loaded) modules in the same directory. The indirect
// caching is required to allow cache invalidation without changing the old
// cache key names.
Expand All @@ -472,17 +474,6 @@ Module._load = function(request, parent, isMain) {
}
}

// Check for native modules first. If we find such name in the user module
// cache, bail out. This keeps the behavior backwards compatible. It was
// originally meant to allow mocking of whole modules by placing a native
// module name in there.
if (NativeModule.nonInternalExists(request)) {
if (Module._cache[request] !== undefined)
return Module._cache[request].exports;
debug('load native module %s', request);
return NativeModule.require(request);
}

const filename = Module._resolveFilename(request, parent, isMain);

const cachedModule = Module._cache[filename];
Expand Down