Skip to content

[v8.x] Backport tty fixes #25351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 4 commits into from
Closed

[v8.x] Backport tty fixes #25351

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
067b981
tools: allow input for TTY tests
addaleax Sep 24, 2018
93d10bc
process: allow reading from stdout/stderr sockets
addaleax Sep 24, 2018
02bea99
test: add stdin writable regression test
addaleax Sep 24, 2018
8d6637f
test: add process.stdin.end() TTY regression test
mcollina Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add process.stdin.end() TTY regression test 
PR-URL: #23051
Fixes: #22814
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@mcollina
mcollina committed Jan 5, 2019
commit 8d6637f6c0f32fe8d6b7b1d8bb964ac21a30f281
8 changes: 8 additions & 0 deletions test/pseudo-tty/test-tty-stdin-call-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
'use strict';

require('../common');

// This tests verifies that process.stdin.end() does not
// crash the process with ENOTCONN

process.stdin.end();
Empty file added test/pseudo-tty/test-tty-stdin-call-end.out
View file
Open in desktop
Empty file.