Skip to content

lib,test: remove lib/internal/test/unicode.js #25298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

lib,test: remove lib/internal/test/unicode.js #25298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60a9ad5
lib,test: remove lib/internal/test/unicode.js
Trott Jan 1, 2019
68e8ad2
fixup! lib,test: remove lib/internal/test/unicode.js
Trott Jan 3, 2019
836d23b
fixup! fixup! lib,test: remove lib/internal/test/unicode.js
Trott Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib,test: remove lib/internal/test/unicode.js 
Remove lib/internal/test/unicode.js and associated test. When we added
the file and test, only comments in lib had non-ASCII characters. Now,
lib/internal/cli_table.js has non-ASCII characters. Tests that exercise
the `console.table()` therefore fulfill the need to test non-ASCII
characters in built-in modules.
  • Loading branch information
@Trott
Trott committed Jan 1, 2019
commit 60a9ad5718cbd0631dc4f9d62cc58df613574e3a
8 changes: 0 additions & 8 deletions lib/internal/test/unicode.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@
'lib/internal/socket_list.js',
'lib/internal/test/binding.js',
'lib/internal/test/heap.js',
'lib/internal/test/unicode.js',
'lib/internal/timers.js',
'lib/internal/tls.js',
'lib/internal/trace_events_async_hooks.js',
Expand Down
12 changes: 0 additions & 12 deletions test/parallel/test-internal-unicode.js
View file
Open in desktop

This file was deleted.