Skip to content

doc: revise "Breaking Changes to Internal Elements" #25190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

doc: revise "Breaking Changes to Internal Elements" #25190

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e3b7c0
doc: revise "Breaking Changes to Internal Elements"
Trott Dec 23, 2018
5b10190
fixup! doc: revise "Breaking Changes to Internal Elements"
Trott Dec 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! doc: revise "Breaking Changes to Internal Elements"
  • Loading branch information
@Trott
Trott committed Dec 25, 2018
commit 5b1019020793acdf6cedf9c6c53a59e2f33e3df5
13 changes: 7 additions & 6 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,12 +269,13 @@ For more information, see [Deprecations](#deprecations).

#### Breaking Changes to Internal Elements

Breaking changes to internal elements may be semver-patch or semver-minor.
Collaborators should take significant care when making and reviewing such
changes. An effort must be made to determine the potential impact of the change
in the ecosystem. Use [Canary in the Goldmine](https://github.com/nodejs/citgm)
to test such changes. If a change will cause ecosystem breakage, then it is
semver-major. Consider providing a Public API in such cases.
Breaking changes to internal elements may occur in semver-patch or semver-minor
commits. Collaborators should take significant care when making and reviewing
such changes. An effort must be made to determine the potential impact of the
change in the ecosystem. Use
[Canary in the Goldmine](https://github.com/nodejs/citgm) to test such changes.
If a change will cause ecosystem breakage, then it is semver-major. Consider
providing a Public API in such cases.

#### When Breaking Changes Actually Break Things

Expand Down