Skip to content

test,tools: move Flags: comment processing from Python to JavaScript #25167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 40 commits into from
Closed

test,tools: move Flags: comment processing from Python to JavaScript #25167

Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
4cdc61e
test: add common.exposeInternals()
Trott Dec 19, 2018
104854c
test: add common.relaunchWithFlags()
Trott Dec 19, 2018
afdddac
test: use common.relaunchWithFlags() for --expose-gc
Trott Dec 19, 2018
510fe11
test: introduce common.experimentalWorker()
Trott Dec 19, 2018
98fabd8
test: use common.relaunchWithFlags() for --no-force-async-hooks-check
Trott Dec 19, 2018
648a7c4
test: use --experimental-modules automatically for es-module tests
Trott Dec 20, 2018
6021445
test: use common.relaunchWithFlags() for --inspect=0
Trott Dec 21, 2018
4329520
test: use common.relaunchWithFlags() for --trace-warnings
Trott Dec 21, 2018
169b43f
test: use common.relaunchWithFlags() for --no-warnings
Trott Dec 21, 2018
013dd61
test: use common.relaunchWithFlags() for --pending-deprecations
Trott Dec 21, 2018
50b7fa6
test: use common.relaunchWithFlags() for --zero-fill-buffers
Trott Dec 21, 2018
df816e3
test: use common.relaunchWithFlags() for '--debug-code'
Trott Dec 21, 2018
2078385
test: use common.relaunchWithFlags() for --expose-externalize-string
Trott Dec 21, 2018
ed8e54b
test: use common.relaunchWithFlags() for --allow-natives-syntax
Trott Dec 21, 2018
2429547
test: use common.relaunchWithFlags() for --tls-v1.* flags
Trott Dec 21, 2018
1dce939
test: remove unneeded use of --no-deprecation
Trott Dec 21, 2018
4817b2b
test: use common.relaunchWithFlags() for --preserve-symlinks
Trott Dec 21, 2018
3a5b5d7
test: use common.relaunchWithFlags() for special-case --expose-internals
Trott Dec 21, 2018
6eecd13
test: use common.relaunchWithFlags() for --abort-on-uncaught-exception
Trott Dec 21, 2018
35e141c
test: use common.relaunchWithFlags() for --title
Trott Dec 21, 2018
33a7f0f
test: use common.relaunchWithFlags for --experimental-repl-await
Trott Dec 21, 2018
3c5cd68
test: use common.relaunchWithFlags() for --use-bundled-ca
Trott Dec 21, 2018
e9ff344
test: use common.relaunchWithFlags() for --experimental-vm-modules
Trott Dec 21, 2018
c662003
test: use common.relaunchWithFlags() for --max-old-space-size
Trott Dec 21, 2018
482ef23
test: use common.relaunchWithFlags() for --require
Trott Dec 21, 2018
ad858a9
test: remove check for Flags: in common module
Trott Dec 19, 2018
97b2101
test: remove Flags: functionality from Python test runner
Trott Dec 21, 2018
2fbf88f
test: implement common.requireFlags()
Trott Dec 26, 2018
7bb8b47
test: wrap common.requireFlags() with common.exposeInternals()
Trott Dec 27, 2018
ec18dcd
test: remove common.exposeInternals()
Trott Dec 27, 2018
3c8c66e
test: remove common.experimentalWorker()
Trott Dec 27, 2018
f9a3f5d
test: remove common.relaunchWithFlags()
Trott Dec 27, 2018
d4eb09d
test: remove unnecessary logic around requireFlags() calls
Trott Dec 27, 2018
cec4d0e
test: revise signature for common.requireFlags()
Trott Dec 28, 2018
7b50eb6
fixup on experimental worker flag
Trott Jan 4, 2019
e716c0a
test: improve worker_threads handling in common.requireFlags()
Trott Dec 28, 2018
539d365
test: check for errors after in requireFlags()
Trott Dec 30, 2018
ac1913b
test: refactor test-inspector-overwrite-config.js
Trott Dec 30, 2018
bdcbdae
test: short-circuit requireFlags() when cluster worker
Trott Dec 31, 2018
146681b
test: simplify flags logic for esm tests
Trott Jan 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: check for errors after in requireFlags()
  • Loading branch information
@Trott
Trott committed Jan 4, 2019
commit 539d365c92d4de2b315c060c4ce7a87aebf33a33
1 change: 1 addition & 0 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,7 @@ function requireFlags(...flags) {
const args = [ ...missing, ...process.execArgv, ...process.argv.slice(1) ];
const options = { encoding: 'utf8', stdio: 'inherit' };
const result = spawnSync(process.execPath, args, options);
assert.ifError(result.error);
process.exit(result.status);
Comment thread
Trott marked this conversation as resolved.
Outdated
}
}
Expand Down