Skip to content

test: prepare test-whatwg-encoding-* to be ported to WPT if possible #25155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 5 commits into from
Closed

test: prepare test-whatwg-encoding-* to be ported to WPT if possible #25155

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71e9d46
test: split test-whatwg-encoding-textdecoder.js
joyeecheung Dec 20, 2018
7d141f8
test: split test-whatwg-encoding-textdecoder-fatal.js
joyeecheung Dec 20, 2018
6a9da16
test: split encoding tests where some cases can be run without ICU
joyeecheung Dec 20, 2018
d70ad5f
test: rename custom encoding tests that cannot be replaced by WPT
joyeecheung Dec 20, 2018
48c74f1
test: add TODO to encoding tests that can be replaced with WPT
joyeecheung Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: split test-whatwg-encoding-textdecoder-fatal.js 
Split `test-whatwg-encoding-textdecoder-fatal.js` into

- `test-whatwg-encoding-custom-textdecoder-fatal.js` which
  is a customized version of the WPT that tests for Node.js-specific
  error codes.
- `test-whatwg-encoding-custom-textdecoder-invalid-arg` which
  tests `ERR_INVALID_ARG_TYPE`
  • Loading branch information
@joyeecheung
joyeecheung committed Dec 20, 2018
commit 7d141f83d292a755adf1b14c0289be23c01221df
14 changes: 2 additions & 12 deletions ...test-whatwg-encoding-textdecoder-fatal.js → ...atwg-encoding-custom-textdecoder-fatal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

// From: https://github.com/w3c/web-platform-tests/blob/39a67e2fff/encoding/textdecoder-fatal.html
// With the twist that we specifically test for Node.js error codes

const common = require('../common');

Expand Down Expand Up @@ -82,21 +83,10 @@ bad.forEach((t) => {
);
});

// TODO(joyeecheung): remove this when WPT is ported
{
assert('fatal' in new TextDecoder());
assert.strictEqual(typeof new TextDecoder().fatal, 'boolean');
assert(!new TextDecoder().fatal);
assert(new TextDecoder('utf-8', { fatal: true }).fatal);
}

{
const notArrayBufferViewExamples = [false, {}, 1, '', new Error()];
notArrayBufferViewExamples.forEach((invalidInputType) => {
common.expectsError(() => {
new TextDecoder(undefined, null).decode(invalidInputType);
}, {
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError
});
});
}
18 changes: 18 additions & 0 deletions test/parallel/test-whatwg-encoding-custom-textdecoder-invalid-arg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';

// This tests that ERR_INVALID_ARG_TYPE are thrown when
// invalid arguments are passed to TextDecoder.

const common = require('../common');

{
const notArrayBufferViewExamples = [false, {}, 1, '', new Error()];
notArrayBufferViewExamples.forEach((invalidInputType) => {
common.expectsError(() => {
new TextDecoder(undefined, null).decode(invalidInputType);
}, {
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError
});
});
}