Skip to content

test: refactor test-esm-namespace.mjs #25117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: refactor test-esm-namespace.mjs #25117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor test-esm-namespace.mjs 
Remove unused `name` argument that is different from a subsequent `name`
argument in a different but nearby function. This was mildly confusing
to me at first, so hopefully this change clarifies things for others
reading the test.
  • Loading branch information
@Trott
Trott committed Dec 19, 2018
commit 2a21da6ace028f1469e435b1da0d2ac099621af2
2 changes: 1 addition & 1 deletion test/es-module/test-esm-namespace.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import Module from 'module';

const keys = Object.entries(
Object.getOwnPropertyDescriptors(new Module().require('fs')))
.filter(([name, d]) => d.enumerable)
.filter(([ , d]) => d.enumerable)
.map(([name]) => name)
.concat('default')
.sort();
Expand Down