Skip to content

test: add missing tmpdir.refresh() in recently-added test #25098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: add missing tmpdir.refresh() in recently-added test #25098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: add missing tmpdir.refresh() in recently-added test 
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: #24913 (comment)
  • Loading branch information
@Trott
Trott committed Dec 17, 2018
commit 4e3df0e731c0719207fd60e4a0d51c42a9e074d7
2 changes: 2 additions & 0 deletions test/parallel/test-child-process-spawn-args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ const { spawn } = require('child_process');
const common = require('../common');
const tmpdir = require('../common/tmpdir');

tmpdir.refresh();

const command = common.isWindows ? 'cd' : 'pwd';
const options = { cwd: tmpdir.path };

Expand Down